HeartSaVioR commented on pull request #31186: URL: https://github.com/apache/spark/pull/31186#issuecomment-761945911
Just found the difference between the twos. #30814 is not only changing the classes to package private, but also adding another constructor to keep compatibility. (so the Mima change could drop based on the resurrection of constructor instead of making classes be package private) Sorry for the miss. I'll create a follow-up PRs. I don't think that's a release blocker though - we changed these classes be package private based on the fact these classes shouldn't be used outside of Spark, so Mima change shouldn't matter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
