dongjoon-hyun commented on a change in pull request #31216:
URL: https://github.com/apache/spark/pull/31216#discussion_r559345691
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -44,4 +44,13 @@ class AlterTableAddPartitionSuite
checkPartitions(t, Map("p1" -> ""))
}
}
+
+ test("SPARK-34143: add a partition to fully partitioned table") {
+ withNamespaceAndTable("ns", "tbl") { t =>
+ sql(s"CREATE TABLE $t (p0 INT, p1 STRING) $defaultUsing PARTITIONED BY
(p0, p1)")
Review comment:
+1 for @cloud-fan 's question. Yes, this is not allowed in DSv1.
```
spark-sql> create table t(a STRING, b STRING) using orc partitioned by (a,b);
Error in query: Cannot use all columns for partition columns
```
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
##########
@@ -44,4 +44,13 @@ class AlterTableAddPartitionSuite
checkPartitions(t, Map("p1" -> ""))
}
}
+
+ test("SPARK-34143: add a partition to fully partitioned table") {
+ withNamespaceAndTable("ns", "tbl") { t =>
+ sql(s"CREATE TABLE $t (p0 INT, p1 STRING) $defaultUsing PARTITIONED BY
(p0, p1)")
Review comment:
+1 for @cloud-fan 's question. Yes, this is not allowed in DSv1.
```sql
spark-sql> create table t(a STRING, b STRING) using orc partitioned by (a,b);
Error in query: Cannot use all columns for partition columns
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
