MaxGekk commented on a change in pull request #31229:
URL: https://github.com/apache/spark/pull/31229#discussion_r559377476
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala
##########
@@ -44,22 +45,25 @@ case class AlterTableAddPartitionExec(
table.name(), existsParts.map(_.ident), table.partitionSchema())
}
- notExistsParts match {
- case Seq() => // Nothing will be done
+ val isTableAltered = notExistsParts match {
+ case Seq() => false // Nothing will be done
case Seq(partitionSpec) =>
val partProp = partitionSpec.location.map(loc => "location" ->
loc).toMap
table.createPartition(partitionSpec.ident, partProp.asJava)
+ true
Review comment:
The v2 API looks inconsistent to me. I do believe either both
`dropPartition` and `createPartition` should return nothing (and indicate
errors via exceptions) or both methods should return `boolean`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
