CodingCat opened a new pull request #31246:
URL: https://github.com/apache/spark/pull/31246


   ### What changes were proposed in this pull request?
   
   upgrade univocity
   
   ### Why are the changes needed?
   
   csv writer actually has an implicit limit on column name length due to 
univocity-parser 2.9.0,
   
   when we initialize a writer 
https://github.com/uniVocity/univocity-parsers/blob/e09114c6879fa6c2c15e7365abc02cda3e193ff7/src/main/java/com/univocity/parsers/common/AbstractWriter.java#L211,
 it calls toIdentifierGroupArray which calls valueOf in NormalizedString.java 
eventually 
(https://github.com/uniVocity/univocity-parsers/blob/e09114c6879fa6c2c15e7365abc02cda3e193ff7/src/main/java/com/univocity/parsers/common/NormalizedString.java#L205-L209)
   
   in that stringCache.get, it has a maxStringLength cap 
https://github.com/uniVocity/univocity-parsers/blob/e09114c6879fa6c2c15e7365abc02cda3e193ff7/src/main/java/com/univocity/parsers/common/StringCache.java#L104
 which is 1024 by default
   
   more details at https://github.com/apache/spark/pull/30972 and 
https://github.com/uniVocity/univocity-parsers/issues/438
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   
   ### How was this patch tested?
   existing UT
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to