cloud-fan commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560624505
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
TakeOrderedAndProject
[cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
- WholeStageCodegen (14)
+ WholeStageCodegen (20)
HashAggregate
[cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count]
[count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
InputAdapter
Exchange
[cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
#1
- WholeStageCodegen (13)
+ WholeStageCodegen (19)
HashAggregate
[cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
[count,count]
Project
[cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
- BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+ SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]
Review comment:
I guess so. The padding expression stops stats propagation in CBO and we
need to fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
