beliefer commented on a change in pull request #31178:
URL: https://github.com/apache/spark/pull/31178#discussion_r561078618
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala
##########
@@ -305,12 +308,21 @@ class UnboundedOffsetWindowFunctionFrame(
inputIterator = input.generateIterator()
// drain the first few rows if offset is larger than one
inputIndex = 0
- while (inputIndex < offset - 1) {
- if (inputIterator.hasNext) inputIterator.next()
- inputIndex += 1
+ if (ignoreNulls) {
+ findNextRowWithNonNullInput()
+ if (nextSelectedRow == EmptyRow) {
+ // Use default values since the offset row whose input value is not
null does not exist.
+ fillDefaultValue(EmptyRow)
+ } else {
+ projection(nextSelectedRow)
+ }
+ } else {
+ while (inputIndex < offset) {
+ selectedRow = WindowFunctionFrame.getNextOrNull(inputIterator)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
