imback82 commented on a change in pull request #31273:
URL: https://github.com/apache/spark/pull/31273#discussion_r561607878
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1086,7 +1086,7 @@ class Analyzer(override val catalogManager:
CatalogManager)
}
view.copy(child = newChild)
case p @ SubqueryAlias(_, view: View) =>
- p.copy(child = resolveViews(view))
+ p.makeCopy(Array(p.identifier, resolveViews(view)))
Review comment:
This is to copy the tags, but seems hacky since `copy` can be called to
remove the tags in other places. Please check
https://github.com/apache/spark/pull/31273#discussion_r561607183 if it makes
sense to add `isView` to `SubqueryAlias`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
