zsxwing commented on pull request #31219:
URL: https://github.com/apache/spark/pull/31219#issuecomment-764732644


   This looks an unnecessary code refactoring. This would cause extra work when 
backporting bug fixes that touch this file. Do we have a strong reason to do 
this? 
   
   > so it is easier to incorporate other StateStores.
   
   Do you plan to build a new StateStore? If so, can we discuss it first before 
doing code refactoring?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to