cloud-fan commented on a change in pull request #31198:
URL: https://github.com/apache/spark/pull/31198#discussion_r561861162



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/BitwiseExpressionsSuite.scala
##########
@@ -18,6 +18,7 @@
 package org.apache.spark.sql.catalyst.expressions
 
 import org.apache.spark.SparkFunSuite
+ import org.apache.spark.sql.catalyst.dsl.expressions._

Review comment:
       nit: remove extra spaces at the beginning

##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -1413,6 +1413,14 @@ object functions {
    */
   def bitwiseNOT(e: Column): Column = withExpr { BitwiseNot(e.expr) }
 
+  /**
+   * Get the value of the bit (0 or 1) at the specified position.

Review comment:
       let's copy the doc from the SQL expression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to