AngersZhuuuu commented on a change in pull request #31272:
URL: https://github.com/apache/spark/pull/31272#discussion_r561614697
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -81,7 +81,7 @@ object StringUtils extends Logging {
/**
* This utility can be used for filtering pattern in the "Like" of "Show
Tables / Functions" DDL
* @param names the names list to be filtered
- * @param pattern the filter pattern, only '*' and '|' are allowed as
wildcards, others will
+ * @param pattern the filter pattern, only '%', '_' and '|' are allowed as
wildcards, others will
Review comment:
> Do we need to add a test for the new wildcard characters supported?
emmm, I am waiting current but test result and fix current failed unit test
and add test for new wildcard.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -81,7 +81,7 @@ object StringUtils extends Logging {
/**
* This utility can be used for filtering pattern in the "Like" of "Show
Tables / Functions" DDL
* @param names the names list to be filtered
- * @param pattern the filter pattern, only '*' and '|' are allowed as
wildcards, others will
+ * @param pattern the filter pattern, only '%', '_' and '|' are allowed as
wildcards, others will
Review comment:
> Do we need to add a test for the new wildcard characters supported?
emmm, I am waiting current but test result and fix current failed unit test
and add test for new wildcard.
Add `WIP` tag for current status.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -81,7 +81,7 @@ object StringUtils extends Logging {
/**
* This utility can be used for filtering pattern in the "Like" of "Show
Tables / Functions" DDL
* @param names the names list to be filtered
- * @param pattern the filter pattern, only '*' and '|' are allowed as
wildcards, others will
+ * @param pattern the filter pattern, only '%', '_' and '|' are allowed as
wildcards, others will
Review comment:
> Do we need to add a test for the new wildcard characters supported?
emmm, I am waiting current test result and fix current failed unit test and
add test for new wildcard.
Add `WIP` tag for current status.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -81,16 +87,16 @@ object StringUtils extends Logging {
/**
* This utility can be used for filtering pattern in the "Like" of "Show
Tables / Functions" DDL
* @param names the names list to be filtered
- * @param pattern the filter pattern, only '*' and '|' are allowed as
wildcards, others will
- * follow regular expression convention, case insensitive
match and white spaces
- * on both ends will be ignored
+ * @param pattern the filter pattern, only '*', '%', '_' and '|' are allowed
as wildcards, others
+ * will follow regular expression convention, case
insensitive match and white
+ * spaces on both ends will be ignored
* @return the filtered names list in order
*/
def filterPattern(names: Seq[String], pattern: String): Seq[String] = {
val funcNames = scala.collection.mutable.SortedSet.empty[String]
pattern.trim().split("\\|").foreach { subPattern =>
try {
- val regex = ("(?i)" + subPattern.replaceAll("\\*", ".*")).r
+ val regex = ("(?i)" + escapeLikeRegex(subPattern, '\\', true)).r
Review comment:
> `escapeLikeRegex(subPattern.replaceAll("\\*", "%", '\\', true)` ? so
we not need to change the behavior of `escapeLikeRegex`.
Goot suggestion, updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
