viirya commented on a change in pull request #31273:
URL: https://github.com/apache/spark/pull/31273#discussion_r561610487
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1363,9 +1368,14 @@ class SessionCatalog(
Utils.classForName("org.apache.spark.sql.expressions.UserDefinedAggregateFunction")
if (clsForUDAF.isAssignableFrom(clazz)) {
val cls =
Utils.classForName("org.apache.spark.sql.execution.aggregate.ScalaUDAF")
- val e = cls.getConstructor(classOf[Seq[Expression]], clsForUDAF,
classOf[Int], classOf[Int])
- .newInstance(input,
- clazz.getConstructor().newInstance().asInstanceOf[Object],
Int.box(1), Int.box(1))
+ val e = cls.getConstructor(
Review comment:
There are some UDAF related change, is it related to the view stuff here?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -558,20 +560,27 @@ object ViewHelper {
catalog: SessionCatalog, child: LogicalPlan): (Seq[Seq[String]],
Seq[String]) = {
def collectTempViews(child: LogicalPlan): Seq[Seq[String]] = {
child.collect {
- case UnresolvedRelation(nameParts, _, _) if
catalog.isTempView(nameParts) =>
- Seq(nameParts)
- case plan if !plan.resolved => plan.expressions.flatMap(_.collect {
+ case s @ SubqueryAlias(_, view: View) if view.isTempView =>
+ Seq(s.identifier.qualifier :+ s.identifier.name)
+ case s: SubqueryAlias if s.getTagValue(SUBQUERY_TYPE_TAG).exists(_ ==
"tempView") =>
Review comment:
+1 if it works, adding tag seems hacky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
