viirya commented on a change in pull request #31258:
URL: https://github.com/apache/spark/pull/31258#discussion_r562258032
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -133,7 +133,7 @@ case class AdaptiveSparkPlanExec(
inputPlan, queryStagePreparationRules, Some((planChangeLogger, "AQE
Preparations")))
}
- @volatile private var currentPhysicalPlan = initialPlan
+ @volatile var currentPhysicalPlan = initialPlan
Review comment:
Exposing a mutable variable seems not a good idea.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/InsertAdaptiveSparkPlan.scala
##########
@@ -101,7 +102,6 @@ case class InsertAdaptiveSparkPlan(
// TODO migrate dynamic-partition-pruning onto adaptive execution.
Review comment:
So DPP is supported and this comment looks out-of-dated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
