yaooqinn commented on a change in pull request #31281:
URL: https://github.com/apache/spark/pull/31281#discussion_r562446776



##########
File path: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java
##########
@@ -54,8 +51,6 @@ public static UTF8String varcharTypeWriteSideCheck(UTF8String 
inputStr, int limi
       if (numChars <= limit) {
         return inputStr;
       } else {
-        // Trailing spaces do not count in the length check. We need to retain 
the trailing spaces
-        // (truncate to length N), as there is no read-time padding for 
varchar type.
         int maxAllowedNumTailSpaces = numChars - limit;

Review comment:
       sgtm




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to