zero323 commented on pull request #31282:
URL: https://github.com/apache/spark/pull/31282#issuecomment-765335958


   We have a typecheck pipeline here, so "How was this patch tested?" should 
state "existing tests".   I think it should also be described as introducing 
user facing change (as this PR changes what structures are considered to be 
valid by the checker. What do you think @HyukjinKwon?).
   
   Other than that, LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to