LuciferYang commented on pull request #31294: URL: https://github.com/apache/spark/pull/31294#issuecomment-765818993
Yes, ` tryDownloadSpark ` method also try to access the Internet, but it doesn't seem necessary to change it, the reasons are as follows: 1. https://github.com/apache/spark/blob/d5d1c84bf44bf64d2c0e118e5c9fa05e2018ddba/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala#L83-L91 will return `None` because internet can't be accessed. 2. `sites` will be `"https://archive.apache.org/dist"; :+ PROCESS_TABLES.releaseMirror` and there is only one more download failure will be printed because internet can't be accessed. ``` 19:50:35.123 WARN org.apache.spark.sql.hive.HiveExternalCatalogVersionsSuite: Failed to download Spark 3.0.1 from https://archive.apache.org/dist/spark/spark-3.0.1/spark-3.0.1-bin-hadoop3.2.tgz: Network is unreachable (connect failed) ``` Then the test will use `PROCESS_TABLES.releaseMirror(SPARK_RELEASE_MIRROR)` to download Spark release package and not access internet, so the access to the Internet behavior in `tryDownloadSpark` method will not affect the test results. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
