Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5574#discussion_r28929956
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/ByteUnit.java ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.network.util;
+
+public enum ByteUnit {
+ BYTE (1),
+ KiB (1024L),
+ MiB ((long) Math.pow(1024L, 2L)),
+ GiB ((long) Math.pow(1024L, 3L)),
+ TiB ((long) Math.pow(1024L, 4L)),
+ PiB ((long) Math.pow(1024L, 5L));
+
+ private ByteUnit(long multiplier) {
+ this.multiplier = multiplier;
+ }
+
+ // Interpret the provided number (d) with suffix (u) as this unit type.
+ // E.g. KiB.interpret(1, MiB) interprets 1MiB as its KiB representation
= 1024k
+ public long interpret(long d, ByteUnit u) {
+ return u.toBytes(d) / multiplier;
+ }
+
+ // Convert the provided number (d) interpreted as this unit type to unit
type (u).
+ public long convert(long d, ByteUnit u) {
+ return toBytes(d) / u.multiplier;
--- End diff --
If you want to be really correct here, you could avoid overflows by playing
with the multipliers instead of converting things to bytes first.
I think what's bugging me is that the semantics of all these methods are a
little weird. It seems like you're trying to cap the maximum amount to be
represented to `Long.MAX_VALUE` *bytes* (so that having `Long.MAX_VALUE` PB,
for example, would be wrong since you can't convert that to bytes). I'm not
sure that's needed, but if you want that, it should be enforced differently
(and not here). Otherwise, I'd rework these methods to avoid overflows where
possible, and throw exceptions when they would happen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
