cloud-fan commented on a change in pull request #31281:
URL: https://github.com/apache/spark/pull/31281#discussion_r563521153
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/util/PartitioningUtils.scala
##########
@@ -30,14 +35,33 @@ object PartitioningUtils {
*/
def normalizePartitionSpec[T](
partitionSpec: Map[String, T],
- partColNames: Seq[String],
+ partCols: StructType,
tblName: String,
resolver: Resolver): Map[String, T] = {
+ val rawSchema = CharVarcharUtils.getRawSchema(partCols)
val normalizedPartSpec = partitionSpec.toSeq.map { case (key, value) =>
- val normalizedKey = partColNames.find(resolver(_, key)).getOrElse {
+ val normalizedFiled = rawSchema.find(f => resolver(f.name,
key)).getOrElse {
throw new AnalysisException(s"$key is not a valid partition column in
table $tblName.")
}
- normalizedKey -> value
+
+ val normalizedVal = normalizedFiled.dataType match {
+ case CharType(len) if value != null && value != DEFAULT_PARTITION_NAME
=>
+ val v = value match {
+ case Some(v) => Some(charTypeWriteSideCheck(v.toString, len))
Review comment:
nit:
```
case Some(str: String) => ...
case str: String => ...
case other => other
```
Then we don't need the `v.asInstanceOf[T]` at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
