yaooqinn commented on a change in pull request #31320:
URL: https://github.com/apache/spark/pull/31320#discussion_r563734770
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
##########
@@ -227,10 +227,8 @@ case class InsertIntoHadoopFsRelationCommand(
val staticPartitionPrefix = if (staticPartitions.nonEmpty) {
"/" + partitionColumns.flatMap { p =>
staticPartitions.get(p.name) match {
- case Some(value) =>
- Some(escapePathName(p.name) + "=" + escapePathName(value))
- case None =>
- None
+ case Some(value) => Some(getPartitionPathString(p.name, value))
Review comment:
thanks and the `value` can be reduced too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
