mengxr commented on a change in pull request #28590: URL: https://github.com/apache/spark/pull/28590#discussion_r563956258
########## File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringMetrics.scala ########## @@ -0,0 +1,575 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.ml.evaluation + +import org.apache.spark.SparkContext +import org.apache.spark.annotation.Since +import org.apache.spark.broadcast.Broadcast +import org.apache.spark.ml.linalg.{BLAS, DenseVector, Vector, Vectors} +import org.apache.spark.ml.util.MetadataUtils +import org.apache.spark.sql.{Column, DataFrame, Dataset} +import org.apache.spark.sql.functions._ +import org.apache.spark.sql.types.DoubleType + + +/** + * Metrics for clustering, which expects two input columns: prediction and label. + */ +@Since("3.1.0") +class ClusteringMetrics private[spark](dataset: Dataset[_]) { + + private var distanceMeasure: String = "squaredEuclidean" + + def getDistanceMeasure: String = distanceMeasure + + def setDistanceMeasure(value: String) : Unit = distanceMeasure = value + + /** + * Returns the silhouette score + */ + @Since("3.1.0") + lazy val silhouette: Double = { Review comment: This method will trigger I/O. By convention you should have `()` in the defintion. ########## File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringMetrics.scala ########## @@ -0,0 +1,575 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.ml.evaluation + +import org.apache.spark.SparkContext +import org.apache.spark.annotation.Since +import org.apache.spark.broadcast.Broadcast +import org.apache.spark.ml.linalg.{BLAS, DenseVector, Vector, Vectors} +import org.apache.spark.ml.util.MetadataUtils +import org.apache.spark.sql.{Column, DataFrame, Dataset} +import org.apache.spark.sql.functions._ +import org.apache.spark.sql.types.DoubleType + + +/** + * Metrics for clustering, which expects two input columns: prediction and label. + */ +@Since("3.1.0") +class ClusteringMetrics private[spark](dataset: Dataset[_]) { + + private var distanceMeasure: String = "squaredEuclidean" + + def getDistanceMeasure: String = distanceMeasure + + def setDistanceMeasure(value: String) : Unit = distanceMeasure = value Review comment: Should set return `self.type`? When we have more setters it is easier to chain. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
