xkrogen commented on pull request #31333: URL: https://github.com/apache/spark/pull/31333#issuecomment-767161013
I think the main point which may be contentious is having two `IncompatibleSchemaException` nested inside one another, one "top-level" which shows the two full schemas (Avro and Catalyst) being compared, and one specific one thrown from the site of the issue which has details on the exact mismatch. I think it's really helpful for debugging purposes to be able to see the full context -- many times I have gotten support requests from users with schema issues and I have a hard time tracking down exactly what schema they were using (it might not even be the schema they expected they were using, for example if there was a class name conflict with the Avro class they extracted the schema from). If people don't like the nested exception approach, I'm also open to including the full schemas as a message suffix on the individual exceptions that are thrown. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
