wangyum commented on a change in pull request #26804:
URL: https://github.com/apache/spark/pull/26804#discussion_r564112793
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
##########
@@ -127,6 +127,9 @@ class ParquetFileFormat
conf.setEnum(ParquetOutputFormat.JOB_SUMMARY_LEVEL, JobSummaryLevel.NONE)
}
+ // PARQUET-1746: Disables page-level CRC checksums by default.
+ conf.setBooleanIfUnset(ParquetOutputFormat.PAGE_WRITE_CHECKSUM_ENABLED,
false)
Review comment:
1. Disable it to fix this regression:
https://github.com/apache/spark/pull/26804#pullrequestreview-572328921.
2. Writing out checksums has minimal performance impact.
3. Do we really need this feature? I haven't seen Spark SQL users request
this feature. This change just disable it by default, users can still enable
this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
