cloud-fan commented on a change in pull request #31265:
URL: https://github.com/apache/spark/pull/31265#discussion_r563498712
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
##########
@@ -1680,4 +1680,20 @@ abstract class SessionCatalogSuite extends AnalysisTest
with Eventually {
}
}
}
+
+ test("SPARK-34197: refreshTable should not invalidate the relation cache for
temporary views") {
+ withBasicCatalog { catalog =>
+ catalog.createTempView("tbl1", Range(1, 10, 1, 10), false)
+ val qualifiedName1 = QualifiedTableName("default", "tbl1")
+ catalog.cacheTable(qualifiedName1, Range(1, 10, 1, 10))
+ catalog.refreshTable(TableIdentifier("tbl1"))
+ assert(catalog.getCachedTable(qualifiedName1) != null)
+
+ catalog.createGlobalTempView("tbl2", Range(2, 10, 1, 10), false)
+ val qualifiedName2 =
QualifiedTableName(catalog.globalTempViewManager.database, "tbl2")
+ catalog.cacheTable(qualifiedName2, Range(2, 10, 1, 10))
Review comment:
This doesn't seem like a good test because Spark will never put (global)
temp views in the relation cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
