HyukjinKwon commented on a change in pull request #31317:
URL: https://github.com/apache/spark/pull/31317#discussion_r564179295
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -89,6 +89,8 @@ private[spark] object HiveUtils extends Logging {
| Use Hive jars configured by `spark.sql.hive.metastore.jars.path`
Review comment:
Is it a typo above?
```
This property can be one of four options: "
```
->
```
This property can be one of four options:
```
?
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -89,6 +89,8 @@ private[spark] object HiveUtils extends Logging {
| Use Hive jars configured by `spark.sql.hive.metastore.jars.path`
| in comma separated format. Support both local or remote paths.
| 4. A classpath in the standard format for both Hive and Hadoop.
Review comment:
I would add a newline here after this sentence
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -89,6 +89,8 @@ private[spark] object HiveUtils extends Logging {
| Use Hive jars configured by `spark.sql.hive.metastore.jars.path`
| in comma separated format. Support both local or remote paths.
Review comment:
How about we just fix in 3. and 4., and adding one line for each item
like:
```scala
| in comma separated format. Support both local or remote paths. The
provided jars
| should be the same version as ${HIVE_METASTORE_VERSION}.
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
