peter-toth commented on pull request #28885: URL: https://github.com/apache/spark/pull/28885#issuecomment-767530441
Now that https://github.com/apache/spark/pull/31243 got merged the invalid reuse references (`Reuses operator id: unknown`) show up in many golden files. Each of them mean a missed reuse opportunity and a wrong explain plan. Before this PR: ``` tpcds-plan-stability petertoth$ grep -Ril "Reuses operator id: unknown" . | sort ./approved-plans-v1_4/q14a.sf100/explain.txt ./approved-plans-v1_4/q14a/explain.txt ./approved-plans-v1_4/q14b.sf100/explain.txt ./approved-plans-v1_4/q14b/explain.txt ./approved-plans-v1_4/q23a.sf100/explain.txt ./approved-plans-v1_4/q23a/explain.txt ./approved-plans-v1_4/q23b.sf100/explain.txt ./approved-plans-v1_4/q23b/explain.txt ./approved-plans-v1_4/q47.sf100/explain.txt ./approved-plans-v1_4/q47/explain.txt ./approved-plans-v1_4/q57.sf100/explain.txt ./approved-plans-v1_4/q57/explain.txt ./approved-plans-v2_7/q14.sf100/explain.txt ./approved-plans-v2_7/q14/explain.txt ./approved-plans-v2_7/q14a.sf100/explain.txt ./approved-plans-v2_7/q14a/explain.txt ./approved-plans-v2_7/q18a.sf100/explain.txt ./approved-plans-v2_7/q22a.sf100/explain.txt ./approved-plans-v2_7/q22a/explain.txt ./approved-plans-v2_7/q36a.sf100/explain.txt ./approved-plans-v2_7/q36a/explain.txt ./approved-plans-v2_7/q47.sf100/explain.txt ./approved-plans-v2_7/q47/explain.txt ./approved-plans-v2_7/q51a.sf100/explain.txt ./approved-plans-v2_7/q51a/explain.txt ./approved-plans-v2_7/q57.sf100/explain.txt ./approved-plans-v2_7/q57/explain.txt ./approved-plans-v2_7/q5a.sf100/explain.txt ./approved-plans-v2_7/q5a/explain.txt ./approved-plans-v2_7/q67a.sf100/explain.txt ./approved-plans-v2_7/q67a/explain.txt ./approved-plans-v2_7/q70a.sf100/explain.txt ./approved-plans-v2_7/q70a/explain.txt ./approved-plans-v2_7/q77a.sf100/explain.txt ./approved-plans-v2_7/q77a/explain.txt ./approved-plans-v2_7/q80a.sf100/explain.txt ./approved-plans-v2_7/q80a/explain.txt ./approved-plans-v2_7/q86a.sf100/explain.txt ./approved-plans-v2_7/q86a/explain.txt ``` After this PR: ``` tpcds-plan-stability petertoth$ grep -Ril "Reuses operator id: unknown" . | sort tpcds-plan-stability petertoth$ ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
