Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5637#issuecomment-95486611
The difference between this patch and #5592 is that the latter was trying
to use <zip> in Ant to handle the JAR creation everywhere. This patch doesn't
do that: it provides a structured solution to the problem "build against Java
7+ binaries and yet still have a spark-assembly that pyspark, Zepplin &c can
handle"
it adds a new profile for repackaging the JAR with the java6 `bin\jar`
tool. It's not something you'd normally do, except as part of building a
redistributable. What it will mean is that the "just build with Java6" bits of
the docs aren't needed, instead it becomes use `-Prepackage` with
`-Djar.too=$JDK6_HOME\bin\jar`
Having it in the build means its something that Jenkins can be set up to
do, with no need for extra steps in the process. In particular, the re-jar
takes place *before* the JAR is installed into the local `~/.m2` repository, so
is automatically ready for downstream use. If the profile is used for any ASF
releases, it will also push out to maven central a usable JAR file, even when
java7 is used for the build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
