gengliangwang opened a new pull request #31349:
URL: https://github.com/apache/spark/pull/31349


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   In Spark ANSI mode, the type coercion rules are based on the type precedence 
lists of the input data types. 
   As per the section "Type precedence list determination" of "ISO/IEC 
9075-2:2011
   Information technology — Database languages - SQL — Part 2: Foundation 
(SQL/Foundation)", the type precedence lists of primitive data types are as 
following:
   
   - Byte: Byte, Short, Int, Long, Decimal, Float, Double
   - Short: Short, Int, Long, Decimal, Float, Double
   - Int: Int, Long, Decimal, Float, Double
   - Long: Long, Decimal, Float, Double
   - Decimal: Any wider Numeric type
   - Float: Float, Double
   - Double: Double
   - String: String
   - Date: Date, Timestamp
   - Timestamp: Timestamp
   - Binary: Binary
   - Boolean: Boolean
   - Interval: Interval
   
   As for complex data types, Spark will determine the precedent list 
recursively based on their sub-types.
   
   - With the definition of type precedent list, the general type coercion 
rules are as following:
   - Data type S is allowed to be implicitly cast as type T iff T is in the 
precedence list of S
   - Comparison is allowed iff the data type precedence list of both sides has 
at least one common element. When evaluating the comparison, Spark casts both 
sides as the tightest common data type of their precedent lists.
   - There should be at least one common data type among all the children's 
precedence lists for the following operators. The data type of the operator is 
the tightest common precedent data type.
   ```
    In, Except(odd), Intersect, Greatest, Least, Union, If, CaseWhen, 
CreateArray, Array Concat,Sequence, MapConcat, CreateMap
   ```
   
   - For complex types (struct, array, map), Spark recursively looks into the 
element type and applies the rules above. If the element nullability is 
converted from true to false, add runtime null check to the elements.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   The current type coercion rules are complex. Also, they are very hard to 
describe and understand. For details please refer the attached documentation 
"Default Type coercion rules of Spark"
   [Default Type coercion rules of 
Spark.pdf](https://github.com/apache/spark/files/5874362/Default.Type.coercion.rules.of.Spark.pdf)
   
   
   This PR is to create a new and strict type coercion system under ANSI mode. 
The rules are simple and clean, so that users can follow them easily
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes,  new implicit cast syntax rules in ANSI mode
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   Unit tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to