imback82 commented on a change in pull request #31352:
URL: https://github.com/apache/spark/pull/31352#discussion_r565027977
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
##########
@@ -53,38 +53,42 @@ import org.apache.spark.sql.catalyst.rules.Rule
* completely resolved during the batch of Resolution.
*/
object EliminateView extends Rule[LogicalPlan] with CastSupport {
- override def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
- // The child has the different output attributes with the View operator.
Adds a Project over
- // the child of the view.
- case v @ View(desc, _, output, child) if child.resolved &&
!v.sameOutput(child) =>
- val resolver = conf.resolver
- val queryColumnNames = desc.viewQueryColumnNames
- val queryOutput = if (queryColumnNames.nonEmpty) {
- // Find the attribute that has the expected attribute name from an
attribute list, the names
- // are compared using conf.resolver.
- // `CheckAnalysis` already guarantees the expected attribute can be
found for sure.
- desc.viewQueryColumnNames.map { colName =>
- child.output.find(attr => resolver(attr.name, colName)).get
- }
- } else {
- // For view created before Spark 2.2.0, the view text is already fully
qualified, the plan
- // output is the same with the view output.
- child.output
- }
- // Map the attributes in the query output to the attributes in the view
output by index.
- val newOutput = output.zip(queryOutput).map {
- case (attr, originAttr) if !attr.semanticEquals(originAttr) =>
- // `CheckAnalysis` already guarantees that the cast is a up-cast for
sure.
- Alias(cast(originAttr, attr.dataType), attr.name)(exprId =
attr.exprId,
- qualifier = attr.qualifier, explicitMetadata = Some(attr.metadata))
- case (_, originAttr) => originAttr
- }
- Project(newOutput, child)
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ AnalysisHelper.allowInvokingTransformsInAnalyzer {
+ plan transformUp {
Review comment:
Thanks @HyukjinKwon for the suggestion! Since
`allowInvokingTransformsInAnalyzer` introduces one more indentation, I had to
move it to align with `override`, which I am not sure is the style we want to
follow. Please let me know!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
