attilapiros commented on a change in pull request #31363:
URL: https://github.com/apache/spark/pull/31363#discussion_r565516665
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/LocalityPlacementStrategySuite.scala
##########
@@ -33,7 +33,7 @@ class LocalityPlacementStrategySuite extends SparkFunSuite {
test("handle large number of containers and tasks (SPARK-18750)") {
// Run the test in a thread with a small stack size, since the original
issue
// surfaced as a StackOverflowError.
- var error: Throwable = null
+ @volatile var error: Throwable = null
Review comment:
As this is set from another thread so this must be either volatile or
the access synchronized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
