cloud-fan commented on a change in pull request #31368:
URL: https://github.com/apache/spark/pull/31368#discussion_r565560459
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -422,41 +422,6 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
case write: V2WriteCommand if write.resolved =>
write.query.schema.foreach(f =>
TypeUtils.failWithIntervalType(f.dataType))
- // If the view output doesn't have the same number of columns
neither with the child
- // output, nor with the query column names, throw an
AnalysisException.
- // If the view's child output can't up cast to the view output,
- // throw an AnalysisException, too.
- case v @ View(desc, _, output, child) if child.resolved &&
!v.sameOutput(child) =>
Review comment:
This is not needed anymore, because
1. `View.output` now directly comes from `child.output`
2. The `UpCast` is added to the plan, and will go through its own error
reporting branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
