Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5550#discussion_r28952947
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -283,6 +285,18 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
val stage = stageSubmitted.stageInfo
activeStages(stage.stageId) = stage
pendingStages.remove(stage.stageId)
+
+ // If a stage retries again, it should be removed from
completedStageIndices set
+ for (
+ activeJobsDependentOnStage <-
stageIdToActiveJobIds.get(stage.stageId);
+ jobId <- activeJobsDependentOnStage;
+ jobData <- jobIdToData.get(jobId)
+ ) {
+ if (jobData.completedStageIndices.contains(stage.stageId)) {
--- End diff --
Oh I see you made this change already. I don't think you have to check
`contains` to `remove` it; it won't do anything if not present. Why the loop
here -- can this not happen in the same loop farther down?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
