HeartSaVioR commented on a change in pull request #31355:
URL: https://github.com/apache/spark/pull/31355#discussion_r565789213
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/ClusteredDistribution.java
##########
@@ -32,4 +32,13 @@
* Returns clustering expressions.
*/
Expression[] clustering();
+
+ /**
+ * Returns the number of partitions required by this write.
+ * <p>
+ * Implementations may want to override this if it requires the specific
number of partitions.
+ *
+ * @return the required number of partitions, non-positive values mean no
requirement.
+ */
+ default int requiredNumPartitions() { return 0; }
Review comment:
I'm trying to not over-engineering here; this PR addresses the actual
use case and no more. If we'd like to address more, I'd like to see the actual
use case or at least possible scenario for each one. Like describing the
characteristic of specific storage and how the functionality will help or why
the functionality is required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
