Ngone51 commented on a change in pull request #31373:
URL: https://github.com/apache/spark/pull/31373#discussion_r565952057
##########
File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala
##########
@@ -128,14 +128,16 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
// Messages received from executors
case heartbeat @ Heartbeat(executorId, accumUpdates, blockManagerId,
executorUpdates) =>
+ var reregisterBlockManager = !sc.isStopped
Review comment:
This sounds like a race condition that happens during SparkContext
shutdown. So it's also possible that the SparkContext is stopped right after we
sent the `HeartbeatResponse`. In that case, IIUC, the issue will still exist.
Does the current behavior cause any real issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
