maropu commented on a change in pull request #31384:
URL: https://github.com/apache/spark/pull/31384#discussion_r566115941
##########
File path: docs/sql-data-sources-jdbc.md
##########
@@ -202,13 +202,27 @@ the following case-insensitive options:
<td><code>keytab</code></td>
<td>
Location of the kerberos keytab file (which must be pre-uploaded to all
nodes either by <code>--files</code> option of spark-submit or manually) for
the JDBC client. When path information found then Spark considers the keytab
distributed manually, otherwise <code>--files</code> assumed. If both
<code>keytab</code> and <code>principal</code> are defined then Spark tries to
do kerberos authentication.
+ It worth to mention that kerberos authentication with keytab is not
always supported by the JDBC driver.<br><br>
+ Before using this feature please make sure the following requirements met:
+ <ol>
+ <li> The included JDBC driver version supports kerberos
authentication with keytab. </li>
+ <li> There is an embedded connection provider which supports the used
database (many database support already added, but since it's changing please
double check the list). </li>
+ </ol>
+ If any other kind of custom authentication is needed
<code>JdbcConnectionProvider</code> developer API is added which allows
developers to implement it.
</td>
</tr>
<tr>
<td><code>principal</code></td>
<td>
Specifies kerberos principal name for the JDBC client. If both
<code>keytab</code> and <code>principal</code> are defined then Spark tries to
do kerberos authentication.
+ It worth to mention that kerberos authentication with keytab is not
always supported by the JDBC driver.<br><br>
+ Before using this feature please make sure the following requirements met:
+ <ol>
+ <li> The included JDBC driver version supports kerberos
authentication with keytab. </li>
+ <li> There is an embedded connection provider which supports the used
database (many database support already added, but since it's changing please
double check the list). </li>
+ </ol>
+ If any other kind of custom authentication is needed
<code>JdbcConnectionProvider</code> developer API is added which allows
developers to implement it.
Review comment:
This note is the same with the one above, so it looks redundant. How
about making a subsection and describing the note there instead? (just like
[Schema Merging in Parquet
Files](https://spark.apache.org/docs/latest/sql-data-sources-parquet.html#schema-merging))
##########
File path: docs/sql-data-sources-jdbc.md
##########
@@ -202,13 +202,27 @@ the following case-insensitive options:
<td><code>keytab</code></td>
<td>
Location of the kerberos keytab file (which must be pre-uploaded to all
nodes either by <code>--files</code> option of spark-submit or manually) for
the JDBC client. When path information found then Spark considers the keytab
distributed manually, otherwise <code>--files</code> assumed. If both
<code>keytab</code> and <code>principal</code> are defined then Spark tries to
do kerberos authentication.
+ It worth to mention that kerberos authentication with keytab is not
always supported by the JDBC driver.<br><br>
+ Before using this feature please make sure the following requirements met:
+ <ol>
+ <li> The included JDBC driver version supports kerberos
authentication with keytab. </li>
+ <li> There is an embedded connection provider which supports the used
database (many database support already added, but since it's changing please
double check the list). </li>
+ </ol>
+ If any other kind of custom authentication is needed
<code>JdbcConnectionProvider</code> developer API is added which allows
developers to implement it.
Review comment:
Could you add a link to `JdbcConnectionProvider.md`?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.md
##########
@@ -0,0 +1,81 @@
+---
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+# JDBC Connection Provider Handling In Spark
Review comment:
Could you update the index page, too, so that users can find this page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
