Ngone51 commented on a change in pull request #31369:
URL: https://github.com/apache/spark/pull/31369#discussion_r566537278



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -165,10 +165,18 @@ case class StateStoreMetrics(
 
 object StateStoreMetrics {
   def combine(allMetrics: Seq[StateStoreMetrics]): StateStoreMetrics = {
+    val customMetricNames = 
allMetrics.flatMap(_.customMetrics.keySet).map(_.name).toSet

Review comment:
       Maybe you can override `equal()` for the base trait if you have such 
concern.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to