ulysses-you commented on a change in pull request #31372:
URL: https://github.com/apache/spark/pull/31372#discussion_r566647200
##########
File path:
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out
##########
@@ -109,7 +109,7 @@ struct<udf(var_samp(b)):double>
-- !query
SELECT udf(stddev_pop(CAST(b AS Decimal(38,0)))) FROM aggtest
-- !query schema
-struct<udf(stddev_pop(CAST(b AS DECIMAL(38,0)))):double>
+struct<udf(stddev_pop(ansi_cast(b as decimal(38,0)))):double>
Review comment:
Not couple them, just follow the semantics of `NonSQLExpression` to make
child toString instead of sql. `AnsiCast` could be seen as an another issue.
You mean we could override `CastBase.sql` to print `ansi_cast` like what
`CastBase.toString` do ? Seems we have not provided a public api to user with
`AnsiCast`. I wonder if `AnsiCast` is only used in Spark internal and not
exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
