LucaCanali commented on a change in pull request #31367:
URL: https://github.com/apache/spark/pull/31367#discussion_r566734443
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonArrowOutput.scala
##########
@@ -71,10 +77,19 @@ private[python] trait PythonArrowOutput { self:
BasePythonRunner[_, ColumnarBatc
}
try {
if (reader != null && batchLoaded) {
+ val bytesReadStart = reader.bytesRead()
+ val startTime = System.nanoTime()
batchLoaded = reader.loadNextBatch()
+ val deltaTime = System.nanoTime() - startTime
Review comment:
Good point. From what I can see by experimenting, is that this actually
triggers execution, so the time measured here seems to be a relevant value for
the execution time. Ideally we would like to measure on the Python side,
although this seems good enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
