[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

Mon, 01 Feb 2021 06:34:18 -0800 


AngersZhuuuu commented on a change in pull request #31378:
URL: https://github.com/apache/spark/pull/31378#discussion_r567868743



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
##########
@@ -129,7 +129,7 @@ class HiveCommandSuite extends QueryTest with SQLTestUtils 
with TestHiveSingleto
 
     checkAnswer(
       sql(s"SHOW TBLPROPERTIES parquet_tab1('my_key1')"),
-      Row("v1") :: Nil
+      Row("my_key1", "v1") :: Nil

Review comment:
       > Yea we need to keep consistent. The question is which side we should 
follow. What's the behavior in hive?
   
   
![image](https://user-images.githubusercontent.com/46485123/106471775-f58a5b00-64dc-11eb-9aaf-51bfa7e2d785.png)
   
   
![image](https://user-images.githubusercontent.com/46485123/106471914-181c7400-64dd-11eb-9aa7-fe045e3507ec.png)
   
   Seems hive is same as ShowTablePropertiesCommand
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to