beliefer commented on a change in pull request #31402:
URL: https://github.com/apache/spark/pull/31402#discussion_r568299145
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -528,6 +529,10 @@ abstract class RowNumberLike extends
AggregateWindowFunction {
override val updateExpressions: Seq[Expression] = rowNumber + one :: Nil
}
+trait SpecifiedFrameAggregateWindowFunction extends AggregateWindowFunction {
+ override val frame: WindowFrame = SpecifiedWindowFrame(RowFrame,
UnboundedPreceding, CurrentRow)
+}
Review comment:
It seems we no need this trait. If we want window function support using
specified window frame, we just do like this:
`override val frame: WindowFrame = UnspecifiedFrame`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
