Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5447#discussion_r28999930
--- Diff: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala ---
@@ -82,7 +82,7 @@ object PythonRunner {
s"spark-submit is currently only supported for local files: $path")
}
val windows = Utils.isWindows || testWindows
- var formattedPath = if (windows) Utils.formatWindowsPath(path) else
path
+ var formattedPath = Utils.formatPath(path, windows)
--- End diff --
This is the only use of `formatPath` leftover and it doesn't feel
necessary. Instead, how about:
val formattedPath = Try(new
URI(formattedPath).getPath()).getOrElse(formattedPath)
Then you can remove `Utils.formatPath`. Maybe even `Utils.windowsDrive`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
