sarutak commented on a change in pull request #31419:
URL: https://github.com/apache/spark/pull/31419#discussion_r568751209



##########
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
##########
@@ -74,7 +74,9 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite {
       .executeUpdate()
 
     conn.prepareStatement("CREATE TABLE st_with_array (c0 uuid, c1 inet, c2 
cidr," +
-      "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[])")
+      "c3 json, c4 jsonb, c5 uuid[], c6 inet[], c7 cidr[], c8 json[], c9 
jsonb[], c10 xml[], " +

Review comment:
       I mean that some supported non-array types like `numeric`, `varchar`, 
`date` and etc are not tested.
   So, we need to add tests for those types in addition to the types supported 
by this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to