maropu commented on a change in pull request #31286:
URL: https://github.com/apache/spark/pull/31286#discussion_r568260449
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/join.sql
##########
@@ -743,20 +743,20 @@ select * from a left join b on i = x and i = y and x = i;
--
-- test NULL behavior of whole-row Vars, per bug #5025
--
-select t1.q2, count(t2.*)
+select t1.q2, count(t2.q1, t2.q2)
Review comment:
nit: could you leave some comments here about why we updated this test?
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/join.sql
##########
@@ -743,20 +743,20 @@ select * from a left join b on i = x and i = y and x = i;
--
-- test NULL behavior of whole-row Vars, per bug #5025
--
-select t1.q2, count(t2.*)
+select t1.q2, count(t2.q1, t2.q2)
Review comment:
nit: Could you leave some comments here about why we updated the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
