Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5604#discussion_r29012757
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -1051,6 +1060,168 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
throw new NotImplementedError(s"No parse rules for:\n
${dumpTree(a).toString} ")
}
+ protected val windowDefs = new ThreadLocal[Map[String, Seq[ASTNode]]] {
+ override def initialValue() = Map.empty[String, Seq[ASTNode]]
+ }
--- End diff --
It would be great if we can remove this `ThreadLocal`. But if it requires
too much work, I guess it's OK to leave it as is. `ThreadLocal` can always be
error prone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
