ScrapCodes commented on a change in pull request #31436:
URL: https://github.com/apache/spark/pull/31436#discussion_r569123449
##########
File path: build/spark-build-info
##########
@@ -32,7 +32,7 @@ echo_build_properties() {
echo revision=$(git rev-parse HEAD)
echo branch=$(git rev-parse --abbrev-ref HEAD)
echo date=$(date -u +%Y-%m-%dT%H:%M:%SZ)
- echo url=$(git config --get remote.origin.url)
+ echo url=$(git config --get remote.origin.url | sed
's|https://\(.*\)@\(.*\)|https://\2|')
Review comment:
Yes,
```
echo "https://user:p@ssw@#[email protected]/Spark"; | sed
's|https://\(.*\)@\(.*\)|https://\2|'
https://git.apache.org/Spark
```
Secondly, passwords are uri encoded so `@` is converted to `%40`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
