Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5663#discussion_r29014914
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -657,6 +657,9 @@ private[spark] class Client(
case e: ApplicationNotFoundException =>
logError(s"Application $appId not found.")
return (YarnApplicationState.KILLED,
FinalApplicationStatus.KILLED)
+ case ie: IOException =>
+ logError(s"Application $appId occurred an unexpected
IOException.")
+ return (YarnApplicationState.KILLED,
FinalApplicationStatus.KILLED)
--- End diff --
So this fixes this particular case, which is fine, but it seems there's a
deeper underlying issue here: any exception thrown by this method will case the
process to "hang".
So, shouldn't this just catch any exception instead? Then log it with a
generic message (`logError("Exception while monitoring application", e)`) and
be done with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
