saikocat commented on a change in pull request #30902:
URL: https://github.com/apache/spark/pull/30902#discussion_r569308430
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -408,6 +421,23 @@ object JdbcUtils extends Logging {
(rs: ResultSet, row: InternalRow, pos: Int) =>
row.setFloat(pos, rs.getFloat(pos + 1))
+
+ // SPARK-33888 - sql TIME type represents as physical int in millis
+ // Represents a time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision of one millisecond.
Review comment:
Your suggestion makes sense. We can also stuff the info into the
metadata field of the struct field. Let me find sometimes this weekend or over
the new year to try out your suggestion? Will ping you back if I couldn't find
time or manage to get a solution so we can revert the MRs. Thanks a lots for
helping me out!
Should I create a new JIRA ticket and cut a new MR or do you prefer to
consolidate in here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
