srowen commented on a change in pull request #31447:
URL: https://github.com/apache/spark/pull/31447#discussion_r569469103
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java
##########
@@ -46,6 +46,8 @@ private long getKeyOffsetForFixedLengthRecords(int rowId) {
public UnsafeRow appendRow(Object kbase, long koff, int klen,
Object vbase, long voff, int vlen) {
// if run out of max supported rows or page size, return null
+ assert(vlen == this.vlen);
Review comment:
assert or require?
Like is is something that user input can never cause (if there is no bug)?
assert
But otherwise this won't be enabled at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
