Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/spark/pull/5609#discussion_r29019178
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -190,6 +190,10 @@
firstNonEmptyValue(SparkLauncher.DRIVER_EXTRA_CLASSPATH, conf,
props) : null;
List<String> cmd = buildJavaCommand(extraClassPath);
+ // Take Thrift Server as daemon
+ if (isThriftServer(mainClass)) {
--- End diff --
Yeah. I think so. If we take a look at `start-thriftserver.sh` then will
find in `spark-daemon.sh` we use spark-submit to submit the
`org.apache.spark.sql.hive.thriftserver.HiveThriftServer2`.
Then it comes into spark-class, and spark-class use
`org.apache.spark.launcher.Main` to resolve args in which it has:
>if (className.equals("org.apache.spark.deploy.SparkSubmit")) {
builder = new SparkSubmitCommandBuilder(args);
} else {
builder = new SparkClassCommandBuilder(className, args);
}
So I think we start Thrift Server by spark-submit but at the meantime
Thrift Server is sort of daemon process and it should take daemon related
options too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
