cloud-fan commented on a change in pull request #31474:
URL: https://github.com/apache/spark/pull/31474#discussion_r570268936



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowNamespacesSuite.scala
##########
@@ -38,6 +38,12 @@ trait ShowNamespacesSuiteBase extends 
command.ShowNamespacesSuiteBase {
     }.getMessage
     assert(errMsg.contains("Namespace 'dummy' not found"))
   }
+
+  test("SPARK-34359: keep the legacy output schema") {
+    withSQLConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA.key -> "true") {
+      assert(sql("SHOW NAMESPACES").schema.fieldNames.toSeq == 
Seq("databaseName"))

Review comment:
       Usually, people don't rely on the output schema of commands, but some BI 
tools may rely on it and users are not able to update the BI tools. That's why 
I think it deserves a legacy config.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to