rdblue commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r570437357
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala
##########
@@ -32,8 +32,13 @@ import org.apache.spark.util.Utils
trait DataSourceV2ScanExecBase extends LeafExecNode {
- override lazy val metrics = Map(
- "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
+ override lazy val metrics = {
Review comment:
Looks like updating `context.taskMetrics().outputMetrics` is just in our
branch. That just uses the Hadoop FS metrics collection that we use elsewhere,
so it isn't metrics from the source as we want to support in this PR.
I think it would be good to follow up and support metrics on the output
side. It doesn't need to be done here, but metrics are really useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
