viirya commented on a change in pull request #31476:
URL: https://github.com/apache/spark/pull/31476#discussion_r570513249
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/Scan.java
##########
@@ -102,4 +102,13 @@ default MicroBatchStream toMicroBatchStream(String
checkpointLocation) {
default ContinuousStream toContinuousStream(String checkpointLocation) {
throw new UnsupportedOperationException(description() + ": Continuous scan
are not supported");
}
+
+ /**
+ * Returns an array of supported custom metrics with name and description.
+ * By default it returns empty array.
+ */
+ default CustomMetric[] supportedCustomMetrics() {
Review comment:
Hmm, I'm okay on putting it into `SupportsReportMetrics`.
From implementation view, I don't see it is much different. Seems we just
need to additionally check if a `Scan` is a `SupportsReportMetrics` when we
want to get the supported metric list.
Semantically it sounds the same. A scan reports no custom metrics v.s. A
scan does not support custom metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
